Adds support for Skipped and Expected Failure test statuses #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszumski
commented
Dec 1, 2023
| @@ -374,7 +386,15 @@ public struct XCResultFormatter { | |||
|
|
|||
| extension ActionTestMetadata { | |||
| var isFailed: Bool { | |||
| return testStatus != "Success" | |||
| return isSuccessful == false && isSkipped == false | |||
There was a problem hiding this comment.
This was the substantive change. isSuccessful and isSkipped look for specific string values and any others are considered to be a failure.
Ideally this would be an enum in XCResultKit and we could switch on it.
a7ex
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Adjusts the logic for handling test statuses to support all 4 possible values: